<html>
<head><meta charset="utf-8"><title>Triage PR dashboard for rustdoc · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html">Triage PR dashboard for rustdoc</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="235898137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235898137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235898137">(Apr 23 2021 at 19:44)</a>:</h4>
<p>The new triage dashboard is really cool :) but it's not super useful for rustdoc because most PRs are for the compiler or standard library. Would be possible to filter PRs by label? <span class="user-mention" data-user-id="132040">@Manish Goregaokar</span> just added A-rustdoc which we're planning to add automatically to anything that touches <code>src/librustdoc</code> or <code>src/rustdoc-json-types</code>.</p>



<a name="235899390"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235899390" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235899390">(Apr 23 2021 at 19:53)</a>:</h4>
<p>also, if anyone has suggestions for automatically adding labels let me know - I'm digging through highfive now</p>



<a name="235899954"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235899954" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235899954">(Apr 23 2021 at 19:57)</a>:</h4>
<p>hmm I wonder if I can just hack it by adding a notification with no reviewer and a <code>@rustbot label</code> command instead <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span></p>



<a name="235900071"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235900071" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235900071">(Apr 23 2021 at 19:58)</a>:</h4>
<p>I'd recommend a triagebot handler, partially because I want the base "file detection" in triagebot so we can use it for other things.</p>



<a name="235900311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235900311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235900311">(Apr 23 2021 at 20:00)</a>:</h4>
<p>I see <a href="http://relabel.rs">relabel.rs</a>, that looks promising</p>



<a name="235900625"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235900625" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235900625">(Apr 23 2021 at 20:02)</a>:</h4>
<p>it should be its own handler, I suspect, but it may call into shared code with relabel.</p>



<a name="235900658"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235900658" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235900658">(Apr 23 2021 at 20:02)</a>:</h4>
<p>(or at least, that's how I'd expect it to work)</p>



<a name="235900687"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235900687" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235900687">(Apr 23 2021 at 20:02)</a>:</h4>
<p>hmm ok, let me see where it gets called - looks like somewhere in <a href="http://handlers.rs">handlers.rs</a></p>



<a name="235900732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235900732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235900732">(Apr 23 2021 at 20:02)</a>:</h4>
<p>do new PRs have a 'comment_body'?</p>



<a name="235900751"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235900751" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235900751">(Apr 23 2021 at 20:03)</a>:</h4>
<p>I believe so, not sure</p>



<a name="235900828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235900828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235900828">(Apr 23 2021 at 20:03)</a>:</h4>
<p>You can look at the github milestone pr thing</p>



<a name="235901139"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235901139" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235901139">(Apr 23 2021 at 20:05)</a>:</h4>
<p>hmm that looks to be specifically for issues? which seems weird because only PRs get milestones</p>



<a name="235901254"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235901254" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235901254">(Apr 23 2021 at 20:06)</a>:</h4>
<p>is this because github doesn't distinguish between issues and PRs on its backend?</p>



<a name="235902062"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235902062" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235902062">(Apr 23 2021 at 20:13)</a>:</h4>
<p>Ok, so my idea for this is to add a general purpose "set this label when this directory is changed" mechanism, then add a <code>"src/librustdoc": "A-rustdoc"</code> config somewhere</p>



<a name="235902106"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235902106" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235902106">(Apr 23 2021 at 20:13)</a>:</h4>
<p>err I guess triagebot uses toml, not json, but close enough</p>



<a name="235902201"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235902201" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235902201">(Apr 23 2021 at 20:14)</a>:</h4>
<p>I wonder if this belongs under <code>autolabel.rs</code></p>



<a name="235904131"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235904131" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235904131">(Apr 23 2021 at 20:31)</a>:</h4>
<p>do you know how I would get files modified in the PR?</p>



<a name="235904399"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235904399" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235904399">(Apr 23 2021 at 20:33)</a>:</h4>
<p>highfive does it somehow, but I don't see any file handling in triagebot</p>



<a name="235904511"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235904511" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235904511">(Apr 23 2021 at 20:34)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235900071">said</a>:</p>
<blockquote>
<p>I'd recommend a triagebot handler, partially because I want the base "file detection" in triagebot so we can use it for other things.</p>
</blockquote>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span>  did you mean to say highfive here? or are you suggesting that I teach triagebot how to detect modified files?</p>



<a name="235904553"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235904553" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235904553">(Apr 23 2021 at 20:34)</a>:</h4>
<p>I mean triagebot</p>



<a name="235904588"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235904588" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235904588">(Apr 23 2021 at 20:34)</a>:</h4>
<p>ok, let me see how highfive does this then</p>



<a name="235904589"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235904589" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235904589">(Apr 23 2021 at 20:34)</a>:</h4>
<p>there's no difference between issues and prs for github really, just some extra metadata on prs</p>



<a name="235904645"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235904645" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235904645">(Apr 23 2021 at 20:35)</a>:</h4>
<p>triagebot doesn't support file getting from prs today, that's basically the main bit you'd be adding</p>



<a name="235904689"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235904689" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235904689">(Apr 23 2021 at 20:35)</a>:</h4>
<p>got it :)</p>



<a name="235904834"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235904834" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235904834">(Apr 23 2021 at 20:36)</a>:</h4>
<p>oh wow highfive does this by parsing <code>git diff</code> output manually <span aria-label="eyes" class="emoji emoji-1f440" role="img" title="eyes">:eyes:</span></p>



<a name="235904842"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235904842" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235904842">(Apr 23 2021 at 20:36)</a>:</h4>
<p>that seems painful</p>



<a name="235905071"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235905071" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235905071">(Apr 23 2021 at 20:38)</a>:</h4>
<p>aha, <code>e.issue.changes.body</code> looks right</p>



<a name="235906481"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235906481" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235906481">(Apr 23 2021 at 20:50)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235898137">said</a>:</p>
<blockquote>
<p>The new triage dashboard is really cool :) but it's not super useful for rustdoc because most PRs are for the compiler or standard library. Would be possible to filter PRs by label? <span class="user-mention silent" data-user-id="132040">Manish Goregaokar</span> just added A-rustdoc which we're planning to add automatically to anything that touches <code>src/librustdoc</code> or <code>src/rustdoc-json-types</code>.</p>
</blockquote>
<p>Why not use the existing <code>T-rustdoc</code> label?</p>



<a name="235906593"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235906593" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235906593">(Apr 23 2021 at 20:51)</a>:</h4>
<p>oh oops we should really stop using the private stream</p>



<a name="235906682"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235906682" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235906682">(Apr 23 2021 at 20:52)</a>:</h4>
<p><span class="user-mention" data-user-id="132040">@Manish Goregaokar</span> and <span class="user-mention" data-user-id="210316">@GuillaumeGomez</span> and I were talking about how <a href="https://github.com/rust-lang/rust/pull/83813">https://github.com/rust-lang/rust/pull/83813</a> changes lots of rustdoc and really should have pinged a member of the team</p>



<a name="235906722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235906722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235906722">(Apr 23 2021 at 20:52)</a>:</h4>
<p>T-rustdoc is a bad fit because if there's an MCP, our opinion doesn't <em>really</em> matter, but the implementation should be reviewed by a team member</p>



<a name="235906898"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235906898" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235906898">(Apr 23 2021 at 20:54)</a>:</h4>
<p>hmm <span class="user-mention" data-user-id="116122">@simulacrum</span> do you know how to get an example diff from github? I tried <code>curl 'https://api.github.com/search/commits?q=repo:rust-lang/rust+author:jyn514' -H 'Accept: application/vnd.github.v3.diff' -v --http1.1</code> which from the docs <em>should</em> work but it doesn't like it:</p>
<div class="codehilite"><pre><span></span><code>{
  &quot;message&quot;: &quot;If you would like to help us test the Commit Search API during its preview period, you must specify a custom media type in the &#39;Accept&#39; header. Please see the docs for full details.&quot;,
  &quot;documentation_url&quot;: &quot;https://docs.github.com/rest/reference/search#search-commits&quot;
}
</code></pre></div>



<a name="235907232"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235907232" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235907232">(Apr 23 2021 at 20:57)</a>:</h4>
<p>actually I'm not even sure that's the endpoint triagebot is using :/ do you know what format the <code>body</code> is in?</p>



<a name="235911130"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235911130" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235911130">(Apr 23 2021 at 21:16)</a>:</h4>
<p><a href="https://github.com/rust-lang/triagebot/pull/1321">https://github.com/rust-lang/triagebot/pull/1321</a></p>



<a name="235913580"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913580" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913580">(Apr 23 2021 at 21:40)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235906682">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="132040">Manish Goregaokar</span> and <span class="user-mention silent" data-user-id="210316">GuillaumeGomez</span> and I were talking about how <a href="https://github.com/rust-lang/rust/pull/83813">https://github.com/rust-lang/rust/pull/83813</a> changes lots of rustdoc and really should have pinged a member of the team</p>
</blockquote>
<p>Is the idea to set up a triagebot zulip notification for the label so we get a topic created in our stream?</p>



<a name="235913648"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913648" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913648">(Apr 23 2021 at 21:40)</a>:</h4>
<p>no, just to add A-rustdoc so we can use it in the triage board</p>



<a name="235913662"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913662" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913662">(Apr 23 2021 at 21:40)</a>:</h4>
<p>pinging on every single change is way too noisy</p>



<a name="235913707"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913707" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913707">(Apr 23 2021 at 21:41)</a>:</h4>
<p>This wouldn't be a ping, it would just create a topic.</p>



<a name="235913734"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913734" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913734">(Apr 23 2021 at 21:41)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235906722">said</a>:</p>
<blockquote>
<p>T-rustdoc is a bad fit because if there's an MCP, our opinion doesn't <em>really</em> matter, but the implementation should be reviewed by a team member</p>
</blockquote>
<p>That still seems like what <code>T-rustdoc</code> is for though. My understanding is that <code>T-</code> labels just mean "this change is relevant to this team".</p>



<a name="235913745"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913745" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913745">(Apr 23 2021 at 21:41)</a>:</h4>
<p>that still seems super noisy :/ rust-lang/rust gets like 20 prs a day</p>



<a name="235913812"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913812" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913812">(Apr 23 2021 at 21:42)</a>:</h4>
<blockquote>
<p>My understanding is that T- labels just mean "this change is relevant to this team".</p>
</blockquote>
<p>No, T- labels mean "this team should be involved in any rfcbot process on this PR"</p>



<a name="235913843"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913843" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913843">(Apr 23 2021 at 21:42)</a>:</h4>
<p>e.g. if you add T-lang and T-libs and then comment <code>@rfcbot fcp merge</code>, it will require checkboxes from <em>both</em> teams</p>



<a name="235913880"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913880" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913880">(Apr 23 2021 at 21:42)</a>:</h4>
<p>Hmm, I guess. I would just prefer a single label so that I can use GitHub search (wish they would add OR syntax...)</p>



<a name="235913885"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913885" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913885">(Apr 23 2021 at 21:42)</a>:</h4>
<p>which is different from "this happens to change the standard library"</p>



<a name="235913913"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913913" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913913">(Apr 23 2021 at 21:43)</a>:</h4>
<p><span class="user-mention silent" data-user-id="307537">Camelid</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235913880">said</a>:</p>
<blockquote>
<p>Hmm, I guess. I would just prefer a single label so that I can use GitHub search (wish they would add OR syntax...)</p>
</blockquote>
<p>well the idea is there would be very few T-rustdoc PRs at all</p>



<a name="235913918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913918">(Apr 23 2021 at 21:43)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235913745">said</a>:</p>
<blockquote>
<p>that still seems super noisy :/ rust-lang/rust gets like 20 prs a day</p>
</blockquote>
<p>We could have it use the same topic for each message.</p>



<a name="235913925"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913925" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913925">(Apr 23 2021 at 21:43)</a>:</h4>
<p>(but yes OR would be really nice)</p>



<a name="235913941"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913941" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913941">(Apr 23 2021 at 21:43)</a>:</h4>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235913913">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="307537">Camelid</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235913880">said</a>:</p>
<blockquote>
<p>Hmm, I guess. I would just prefer a single label so that I can use GitHub search (wish they would add OR syntax...)</p>
</blockquote>
<p>well the idea is there would be very few T-rustdoc PRs at all</p>
</blockquote>
<p>You mean very few <code>A-rustdoc</code> PRs?</p>



<a name="235913943"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913943" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913943">(Apr 23 2021 at 21:43)</a>:</h4>
<p><span class="user-mention silent" data-user-id="307537">Camelid</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235913918">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235913745">said</a>:</p>
<blockquote>
<p>that still seems super noisy :/ rust-lang/rust gets like 20 prs a day</p>
</blockquote>
<p>We could have it use the same topic for each message.</p>
</blockquote>
<p>personally I would just mute the channel if we did that</p>



<a name="235913949"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913949" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913949">(Apr 23 2021 at 21:43)</a>:</h4>
<p>which kind of defeats the point</p>



<a name="235913970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913970">(Apr 23 2021 at 21:43)</a>:</h4>
<p>Ok, that's not good :)</p>



<a name="235913974"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235913974" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235913974">(Apr 23 2021 at 21:43)</a>:</h4>
<p><span class="user-mention silent" data-user-id="307537">Camelid</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235913941">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="232545">Joshua Nelson</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235913913">said</a>:</p>
<blockquote>
<p><span class="user-mention silent" data-user-id="307537">Camelid</span> <a href="#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc/near/235913880">said</a>:</p>
<blockquote>
<p>Hmm, I guess. I would just prefer a single label so that I can use GitHub search (wish they would add OR syntax...)</p>
</blockquote>
<p>well the idea is there would be very few T-rustdoc PRs at all</p>
</blockquote>
<p>You mean very few <code>A-rustdoc</code> PRs?</p>
</blockquote>
<p>no I mean T-rustdoc - every change to rustdoc would have A-rustdoc, and only those needing FCP would have T-rustdoc</p>



<a name="235914073"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235914073" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235914073">(Apr 23 2021 at 21:44)</a>:</h4>
<p>Hmm, what happens if there's no T- label when you start an FCP? Does rfcbot error?</p>



<a name="235914150"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235914150" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235914150">(Apr 23 2021 at 21:45)</a>:</h4>
<p>I think so, yes. Or just ignores the command</p>



<a name="235914274"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235914274" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235914274">(Apr 23 2021 at 21:46)</a>:</h4>
<p>Well, I still wish we could have only one label, but the benefit of having an autolabeler seems like it would outweigh the cost of having two labels.</p>



<a name="235914723"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235914723" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235914723">(Apr 23 2021 at 21:51)</a>:</h4>
<p>Btw, I think we should still use <code>T-rustdoc</code> for issues because that's what WG-prioritization expects.</p>



<a name="235920295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235920295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235920295">(Apr 23 2021 at 22:52)</a>:</h4>
<p><span class="user-mention" data-user-id="232545">@Joshua Nelson</span> you probably want to listen to the push webhook event (may need to add it to code), and then act on that, IIRC it'll have the diff in the push itself</p>



<a name="235920329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/Triage%20PR%20dashboard%20for%20rustdoc/near/235920329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/Triage.20PR.20dashboard.20for.20rustdoc.html#235920329">(Apr 23 2021 at 22:53)</a>:</h4>
<p>If that doesn't work - not sure it will on new PRs, would need to experiment and I probably won't get a chance to - then synchronize events on PRs</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>